Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add way to retarget specific peers on the network to account for the new LIP advertising feature - Closes #3565 #3671

Merged
merged 7 commits into from
May 28, 2019

Conversation

jondubois
Copy link
Contributor

What was the problem?

There was no way to target specific peers in the network for advanced use cases.

How did I fix it?

Added two new actions for peer targeting.

How to test it?

Run npm run test:integration in lisk-p2p.

Review checklist

Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good, but how does user know about the peerId?

diego-G
diego-G previously approved these changes May 22, 2019
@diego-G diego-G dismissed their stale review May 22, 2019 09:04

I agree with @shuse2 that we need to pass share the peerId to rest of the modules in order to allow them to use the retargetting feature.

@jondubois
Copy link
Contributor Author

@mitsujutsu Did you add the peerId to the request/message in your branch for the banning feature?

@mitsuaki-u
Copy link
Contributor

@mitsujutsu Did you add the peerId to the request/message in your branch for the banning feature?

I did not. However I did create a new function with attaches message rate to the request and message object. Perhaps we can expand that to also include peerId?

@shuse2 shuse2 merged commit bb9b5af into feature/implement-lip-p2p May 28, 2019
@shuse2 shuse2 deleted the 3565-peer_targeting branch June 19, 2019 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants