This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
Add way to retarget specific peers on the network to account for the new LIP advertising feature - Closes #3565 #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
May 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks good, but how does user know about the peerId
?
mitsuaki-u
approved these changes
May 22, 2019
diego-G
previously approved these changes
May 22, 2019
diego-G
dismissed
their stale review
May 22, 2019 09:04
I agree with @shuse2 that we need to pass share the peerId
to rest of the modules in order to allow them to use the retargetting feature.
@mitsujutsu Did you add the |
I did not. However I did create a new function with attaches message rate to the request and message object. Perhaps we can expand that to also include peerId? |
shuse2
approved these changes
May 28, 2019
diego-G
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There was no way to target specific peers in the network for advanced use cases.
How did I fix it?
Added two new actions for peer targeting.
How to test it?
Run
npm run test:integration
inlisk-p2p
.Review checklist