Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Managing list of peers according to LIP004 - Closes #3339 #3830

Merged
merged 45 commits into from
Jun 21, 2019
Merged

Managing list of peers according to LIP004 - Closes #3339 #3830

merged 45 commits into from
Jun 21, 2019

Conversation

diego-G
Copy link

@diego-G diego-G commented Jun 17, 2019

How to test it?

npm run enableLocalIPs && npm run test:integration

Review checklist

@diego-G diego-G self-assigned this Jun 17, 2019
@diego-G diego-G changed the title Managing list of peers peers according to the LIP004 - Closes #3339 Managing list of peers according to LIP004 - Closes #3339 Jun 17, 2019
@diego-G diego-G force-pushed the 3339-managing_whitelisted_fixed_peers branch 4 times, most recently from 6485724 to 98ffd38 Compare June 17, 2019 15:57
ishantiw
ishantiw suggested changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few comments and questions

elements/lisk-p2p/package.json Outdated Show resolved Hide resolved
elements/lisk-p2p/src/p2p_types.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/peer_pool.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/peer_pool.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/peer_pool.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/peer_selection.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/validation.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/validation.ts Outdated Show resolved Hide resolved
Repository owner deleted a comment from ishantiw Jun 19, 2019
Repository owner deleted a comment from ishantiw Jun 19, 2019
Repository owner deleted a comment from ishantiw Jun 19, 2019
Repository owner deleted a comment from ishantiw Jun 19, 2019
@diego-G diego-G force-pushed the 3339-managing_whitelisted_fixed_peers branch 5 times, most recently from af20c93 to 5acc1d1 Compare June 19, 2019 12:41
@diego-G diego-G requested a review from ishantiw June 19, 2019 12:42
@diego-G diego-G requested review from mitsuaki-u and removed request for shuse2 June 19, 2019 13:53
@diego-G diego-G force-pushed the 3339-managing_whitelisted_fixed_peers branch from 5acc1d1 to a2c17ff Compare June 20, 2019 08:19
@diego-G diego-G requested a review from shuse2 June 20, 2019 09:24
ishantiw
ishantiw reviewed Jun 20, 2019
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few comments

elements/lisk-p2p/src/p2p.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/p2p.ts Show resolved Hide resolved
elements/lisk-p2p/src/p2p.ts Outdated Show resolved Hide resolved
@diego-G diego-G requested a review from ishantiw June 20, 2019 11:37
mitsuaki-u
mitsuaki-u approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comments

elements/lisk-p2p/src/p2p.ts Outdated Show resolved Hide resolved
elements/lisk-p2p/src/peer_pool.ts Outdated Show resolved Hide resolved
@diego-G diego-G force-pushed the 3339-managing_whitelisted_fixed_peers branch from af15b93 to 9926a3a Compare June 20, 2019 13:06
jondubois
jondubois suggested changes Jun 20, 2019
View reviewed changes
elements/lisk-p2p/src/p2p.ts Outdated Show resolved Hide resolved
@diego-G diego-G requested a review from jondubois June 21, 2019 08:22
@diego-G diego-G force-pushed the 3339-managing_whitelisted_fixed_peers branch from 09173a6 to c679b49 Compare June 21, 2019 11:48
@jondubois jondubois merged commit 41dda7b into feature/implement-lip-p2p Jun 21, 2019
@diego-G diego-G deleted the 3339-managing_whitelisted_fixed_peers branch July 26, 2019 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

@ishantiw ishantiw ishantiw approved these changes

@jondubois jondubois jondubois approved these changes

@shuse2 shuse2 Awaiting requested review from shuse2

Assignees

@diego-G diego-G

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diego-G @jondubois @ishantiw @mitsuaki-u @karmacoma