Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move BlockSlots class into Dpos Module - Closes #3789 #4059

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Move BlockSlots class into Dpos Module - Closes #3789 #4059

merged 4 commits into from
Aug 8, 2019

Conversation

lsilvs
Copy link
Contributor

@lsilvs lsilvs commented Aug 8, 2019 •
edited
Loading

What was the problem?

BlockSlots class was under Blocks domain even though it is related to DPOS domain.

How did I solve it?

I renamed BlockSlots class to Slots and moved it to DPOS folder.
Additionally, I've removed getTime method as it was misleading and redundant and fixed some no-param-reassign warnings in the class.

How to manually test it?

Start the application and check if the blocks are still created every 10 seconds

Review checklist

@lsilvs lsilvs self-assigned this Aug 8, 2019
michielmulders
michielmulders approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@michielmulders michielmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes!

@shuse2 shuse2 merged commit b71aee2 into feature/introduce_bft_consensus Aug 8, 2019
@shuse2 shuse2 deleted the 3789-move-blockSlots-to-dpos branch August 8, 2019 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@michielmulders michielmulders michielmulders approved these changes

Assignees

@lsilvs lsilvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsilvs @shuse2 @michielmulders