This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix invalid schema - Closes #4077 #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablitovicente
approved these changes
Aug 14, 2019
ManuGowda
previously requested changes
Aug 14, 2019
| } catch (err) { | ||
| error = err; | ||
| } | ||
| expect(error).toBe(undefined); |
There was a problem hiding this comment.
why not to use chai's to.not.throw ? something like this expect(function () {}).to.not.throw();
There was a problem hiding this comment.
with await, it doesn't work well
…skHQ/lisk-sdk into 4077-fix_invalid_schema_usage
ManuGowda
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Transaction response was validated against wrong schema
How did I solve it?
Change the schema to validate
How to manually test it?
Start a node and connect to a network which has transaction inside
Review checklist