This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Export browser and node version from Lisk Client - Closes #6817 #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Export node version of build by default - Export browser version as a subpath /browser from the package
- Export node version by default without Buffer - Add Buffer dependency in browser build
shuse2
approved these changes
Oct 6, 2021
ManuGowda
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6817
How was it solved?
How was it tested?
import * as client from '@liskhq/lisk-client/browsershould work in browser environmentimport * as client from '@liskhq/lisk-clientshould work in node environment