You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
If provided, the callback parameter to a function should be the last one.
Alternatively, if suitable, a Promise can be returned.
Actual behavior
Functions including blockchainReady, nodeStatus, getHeight, newRound, blocks, newBlock have a cb parameter, but it is not the last one in the function declaration (this violates the Node.js convention).
Steps to reproduce
See the test/common/utils/wait_for.js module.
Which version(s) does this affect? (Environment, OS, etc...)
1.2.0
The text was updated successfully, but these errors were encountered:
jondubois
changed the title
Improve parameters for wait_for modulet
Improve parameters for wait_for module
Oct 8, 2018
jondubois
changed the title
Improve parameters for wait_for module
Improve parameters for wait_for util
Oct 8, 2018
jondubois
changed the title
Improve parameters for wait_for util
Improve parameters for wait_for util functions
Oct 8, 2018
Expected behavior
If provided, the callback parameter to a function should be the last one.
Alternatively, if suitable, a Promise can be returned.
Actual behavior
Functions including
blockchainReady
,nodeStatus
,getHeight
,newRound
,blocks
,newBlock
have acb
parameter, but it is not the last one in the function declaration (this violates the Node.js convention).Steps to reproduce
See the
test/common/utils/wait_for.js
module.Which version(s) does this affect? (Environment, OS, etc...)
1.2.0
The text was updated successfully, but these errors were encountered: