This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Apply eslint-rule new-cap - Related to #1597 #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
MaciejBaj
approved these changes
Nov 22, 2018
yatki
reviewed
Nov 22, 2018
| @@ -93,7 +93,7 @@ var modulesLoader = new function() { | |||
| new Account(scope.db, scope.schema, scope.logger, cb); | |||
| }, | |||
| }, | |||
| (err, result) => { | |||
| (__err, result) => { | |||
There was a problem hiding this comment.
why underscore here ? @diego-G
There was a problem hiding this comment.
@diego-G btw didn't you want to remove modules_loader once?
There was a problem hiding this comment.
@yatki When you pass a variable to the callback that you don't use, eslint recommends you to write it that way.
@MaciejBaj I did and I do. I'll open an issue for it after @yatki presents the study about unit.
yatki
approved these changes
Nov 23, 2018
pablitovicente
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review checklist