Unify indexOf & includes usage in exception handling - Closes #2436

[yatki]

What was the problem?

Exception handling has been spread throughout the application and not handled from a central place. Also includes and indexOf changes were being used inconsistently.

How did I fix it?

After discussing with @nazarhussain, I decided that we can't combine all exception handling into a central logic due to complexity of the current architecture. I only replaced inconsistent indexOf usages and used includes in all checks.

How to test it?

Review checklist

• The PR resolves Unify indexOf & includes usage in exception handling #2436
• All new code is covered with unit tests
• All new code was formatted with Prettier
• Linting passes
• Tests pass
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[4miners]

Why indexOf over includes?

[yatki]

@4miners I checked the performance difference between indexOf and includes. Seems like indexOf is more performant on chrome and since we are using node I thought we should stick with indexOf.

See: https://stackoverflow.com/questions/47659972/array-indexof-vs-includes-perfomance-depeding-on-browser-and-needle-position

[yatki]

@4miners after further investigation, I found out with latest version of V8 engine includes is almost as fast as indexOf. So I'm switching to use includes.