This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix misuse of sort method while updating delegates list cache #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4miners
approved these changes
Dec 11, 2018
MaciejBaj
approved these changes
Dec 11, 2018
MaciejBaj
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
sort()method causing the updateDelegateListCache function to not behaviour as expected due to the fact it orders as strings.How did I fix it?
I've added a
compare functionto make sure it orders as numbers.How to test it?
npm run mocha -- test/unit/modules/delegates.jsReview checklist