This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix rounds module init, improved tests #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4miners
requested review from
karmacoma,
diego-G,
LucasIsasmendi,
SargeKhan,
MaciejBaj and
Isabello
test/node.js
Outdated
| modulesLoader.initModuleWithDb(Rounds, function (err, rounds) { | ||
| if (err) { | ||
| return cb(err); | ||
| } | ||
| var nextRound = rounds.calc(height); |
There was a problem hiding this comment.
Since node.js doesn't implement modules or logic and rounds.calc() is more an helper than a module, maybe instead of overload with module inicialization, we can use the plain function from rounds: Math.ceil(height / slots.delegates)
4miners
changed the title
Isabello
previously approved these changes
Jun 12, 2017
karmacoma
approved these changes
Jun 12, 2017
Isabello
approved these changes
Jun 12, 2017
karmacoma
removed
type: bug
type: improvement
type: refactoring
security
type: test
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onNewBlockfunctionpeers.transactions.votesfor compatibility with 1 block wait, improved performance