-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use colons in metric names? #9
Comments
Hi.Thanks for feedback, please star repo and share to friend if you want to see the project developed. This motivates me :-) Regarding names. For your metrics, you can use any format. I do not agree with the recommendations to use colons only for aggregation metrics. From my experience not convenient to use underscore to separate namespaces. I have metric By recommendation I need to use I think that, these names are very inconvenient when you have hundreds of services and applications. |
I'll admit I'm not sure what is common for Prometheus in general, but at my day job we typically solve this by having the monitoring add a Anyway, feel free to close this if you like it the way it is. I can always just use uwsgi_exporter and use pyprometheus for my custom metrics only. In theory this could be configurable, but I'm not convinced it would be worth the trouble, and I'm not going to expect you implement it just because I asked. |
Based on https://www.robustperception.io/on-the-naming-of-things/ and https://prometheus.io/docs/practices/rules/#naming-and-aggregation naming should normally be
level:metric:operations
. This implies that colons are "reserved" for use in aggregation rules, so metrics with colons are a bit confusing and breaks with Prometheus conventions.Also thanks for creating this, was rather sad to see that there wasn't any simple way to get Prometheus + Python UWSGI with the official client, but this looks very promising :-)
The text was updated successfully, but these errors were encountered: