Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some translate literals aren't applied #1417

Closed
oka4shi opened this issue Dec 22, 2023 · 3 comments
Closed

[BUG] Some translate literals aren't applied #1417

oka4shi opened this issue Dec 22, 2023 · 3 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@oka4shi
Copy link
Contributor

oka4shi commented Dec 22, 2023

Environment

Self-Hosted (Docker)

System

No response

Version

2.1.1

Describe the problem

I found a issue, and I determined the cause of that. Could I make a pull request to fix this issue?

Problem

app-info.privacy-and-security-advice and app-info.privacy-and-security-advice-link are not applied in App Info.

This is the screenshot including the inadequacy. I marked the points with yellow lines.
Screenshot

The Cause

The keys of translation files are wrong. This is a link to the incorrect part of the English translation file. The same problem also exists in the translation files for other languages.

https://github.com/Lissy93/dashy/blob/40c9b41805ac67a33b27c669b48c0fa38d7f06dd/src/assets/locales/en.json#L66C14-L66C14

Additional info

No response

Please tick the boxes

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more! - Lissy93/dashy
@oka4shi oka4shi added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Dec 22, 2023
@CrazyWolf13
Copy link
Collaborator

CrazyWolf13 commented Dec 28, 2023

I recommend creating a PR and Lissy93 is much more likely to see this, as she barely writes into issues in the last time as she is busy in private life.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Dec 28, 2023
@CrazyWolf13
Copy link
Collaborator

CrazyWolf13 commented Feb 23, 2024

Created a PR #1471

@CrazyWolf13
Copy link
Collaborator

CrazyWolf13 commented Feb 27, 2024

Should be fixed now, once 2.1.2 will release the changes should take effect.

IF you want to preview it, build from source like described here:
https://github.com/Lissy93/dashy?tab=readme-ov-file#deploying-from-source-

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more! - Lissy93/dashy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants