-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Some translate literals aren't applied #1417
Labels
🐛 Bug
[ISSUE] Ticket describing something that isn't working
Comments
I recommend creating a PR and Lissy93 is much more likely to see this, as she barely writes into issues in the last time as she is busy in private life. |
liss-bot
added
👤 Awaiting Maintainer Response
[ISSUE] Response from repo author is pending
and removed
👤 Awaiting Maintainer Response
[ISSUE] Response from repo author is pending
labels
Dec 28, 2023
3 tasks
Created a PR #1471 |
Should be fixed now, once 2.1.2 will release the changes should take effect. IF you want to preview it, build from source like described here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Self-Hosted (Docker)
System
No response
Version
2.1.1
Describe the problem
I found a issue, and I determined the cause of that. Could I make a pull request to fix this issue?
Problem
app-info.privacy-and-security-advice
andapp-info.privacy-and-security-advice-link
are not applied in App Info.This is the screenshot including the inadequacy. I marked the points with yellow lines.
The Cause
The keys of translation files are wrong. This is a link to the incorrect part of the English translation file. The same problem also exists in the translation files for other languages.
https://github.com/Lissy93/dashy/blob/40c9b41805ac67a33b27c669b48c0fa38d7f06dd/src/assets/locales/en.json#L66C14-L66C14
Additional info
No response
Please tick the boxes
The text was updated successfully, but these errors were encountered: