Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unauthorized user can access /conf.yml #1586

Closed
5 tasks done
Towerism opened this issue May 15, 2024 · 1 comment
Closed
5 tasks done

[BUG] Unauthorized user can access /conf.yml #1586

Towerism opened this issue May 15, 2024 · 1 comment
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Duplicate [ISSUE] This issue or pull request already exists

Comments

@Towerism
Copy link

Environment

Self-Hosted (Docker)

System

Chrome 124.0.6367.201, Debian GNU/Linux 12 (bookworm), Docker 20.10.24+dfsg1 build 297e128

Version

3.1.0

Describe the problem

First of all, thanks for creating this product. It's a beautiful, easy to configure, easy to use dashboard that has made it a pleasure to organize my home network.

Now onto to the bug.

With the following settings:

appConfig.disableConfigurationForNonAdmin: true
appConfig.auth.enableGuestAccess: false

an unauthorized user can access /conf.yml and view the entire config. This seems like a security flaw. Unauthorized users should be denied access to /conf.yml.

Additional info

No response

Please tick the boxes

@Towerism Towerism added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label May 15, 2024
@CrazyWolf13
Copy link
Collaborator

Closed as duplicate of #668

Please look into the docs before creating a new issue; https://dashy.to/docs/authentication

It's explained here.
Also you can find a resolution, for example by adding http basic auth.

Also look at this:
#1579 (comment)

@CrazyWolf13 CrazyWolf13 added the 🕸️ Duplicate [ISSUE] This issue or pull request already exists label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🕸️ Duplicate [ISSUE] This issue or pull request already exists
Projects
Status: Done
Development

No branches or pull requests

3 participants