Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the linuxdeploy GTK plugin to correctly deploy GTK3 dependencies #1708

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Oct 6, 2023

Description

This fixes a number of errors when starting the AppImage on more modern distros than Ubuntu 20.04. We didn't bundle all the GTK3 plugins and libraries into the AppImage, so it wouldn't start. It also was missing the AppRun hook that the GTK plugin installs which allows the AppImage to run without crashing on Wayland.

This doesn't fix the issue with EGL on the AppImage, so VAAPI encoding is still unavailable. The reason for this is that the AppImage bundles libwayland-client.so which is also a dependency of libEGL_mesa.so. On a newer distro, libEGL_mesa.so may depend on symbols present on the host version of libwayland-client.so but not the older version bundled in the AppImage. The missing symbols cause libEGL_mesa.so to fail to load which causes EGL to fail.

Screenshot

Issues Fixed or Closed

Fixes #1702

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit 9c401f5 into LizardByte:nightly Oct 6, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 23.04 host appImage bug
2 participants