Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for improving uninstalling #730

Open
6 of 11 tasks
emilazy opened this issue Jul 11, 2023 · 6 comments · Fixed by #1141
Open
6 of 11 tasks

Tracking issue for improving uninstalling #730

emilazy opened this issue Jul 11, 2023 · 6 comments · Fixed by #1141

Comments

@emilazy
Copy link
Collaborator

emilazy commented Jul 11, 2023

  • Needs to clean up /run, esp. after Install nix-darwin on flake-based systems #687
  • Didn't delete /Applications/Nix Apps
  • Should restore pre-nix-darwin configuration like nix.conf, bashrc and zshrc
  • Change user shells that point to /run/current-system
  • Flake uninstall procedure needs documenting in README
  • Update documentation to try running the uninstaller from $PATH
  • Run checks after user runs uninstaller and direct them to report issues if the uninstaller failed
  • Check that /etc configuration got restored correctly
  • Check that no user shells point to /run/*
  • Check that run is not mentioned in /etc/synthetic.conf
  • Check that the only LaunchDaemons for org.nixos are org.nixos.nix-daemon and org.nixos.darwin-store
@Enzime
Copy link
Collaborator

Enzime commented Jul 11, 2023

I've fixed /Applications/Nix Apps not getting deleted in #687.

As opposed to the installer, I think uninstalling a flake-based system can be handled by the darwin-uninstaller, need to investigate further into any additional flake-specific logic that needs to be added.

@emilazy
Copy link
Collaborator Author

emilazy commented Jul 11, 2023

I've fixed /Applications/Nix Apps not getting deleted in #687.

That's what confuses me: I was using that version (nix run github:Enzime/...).

@Enzime
Copy link
Collaborator

Enzime commented Sep 10, 2023

I believe the uninstaller is not unloading launchd daemons before deleting the files, need to check this further.

@zdcthomas
Copy link

I thought I'd call this out here too, there's a small bootstrapping issue with the uninstaller being a derivation that has to be built to be run. If someone has any issues actually running nix, and they want to uninstall nix-darwin to get back to a clean state, they can't easily do that right now, since the docs recommend running from the derivation

@Enzime
Copy link
Collaborator

Enzime commented May 16, 2024

Some progress was made on this as of #806 as the uninstaller is now installed by default on all nix-darwin systems, accessible through darwin-uninstaller, so it no longer needs to be built, however I believe the uninstaller still depends on Nix.

The documentation should probably be updated to recommend running the uninstaller from $PATH

@Enzime Enzime changed the title Uninstaller needs work Tracking issue for improving uninstalling Oct 22, 2024
@Enzime
Copy link
Collaborator

Enzime commented Nov 4, 2024

Another thing to consider is what we want to do with users and groups created or managed by nix-darwin

@Enzime Enzime mentioned this issue Nov 4, 2024
5 tasks
@Enzime Enzime reopened this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants