Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer incorrectly resolving paths on Windows #71

Closed
noonanwebgroup opened this issue Mar 1, 2021 · 1 comment
Closed

Composer incorrectly resolving paths on Windows #71

noonanwebgroup opened this issue Mar 1, 2021 · 1 comment

Comments

@noonanwebgroup
Copy link
Contributor

Hey there, firstly thanks for this awesome package! I installed it, generated an example block and field as per the docs and I didn't see it being registered on the site. I spent a couple of hours scratching my head and wondered what I was doing wrong. I checked out the docs multiple times to see if there was something I was missing, but apparently not.

As I jumped into the source code, I realised that the composer was incorrectly resolving the path for Windows. It seems as though AcfComposer.php:95 is the issue. Rather than searching for the string '/' you could replace it with DIRECTORY_SEPARATOR to get the correct separator for that OS. After changing it, blocks and fields were registering perfectly.

@noonanwebgroup
Copy link
Contributor Author

I've opened a pull request with the fix #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant