Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding byte[] or Stream overload for Apply() argument #11

Open
longlongago-k opened this issue Jun 6, 2023 · 1 comment
Open

Adding byte[] or Stream overload for Apply() argument #11

longlongago-k opened this issue Jun 6, 2023 · 1 comment

Comments

@longlongago-k
Copy link

Currently, only Func argument supported for telling patch file.
It seems strange for normal usage.
And also concerned about disposing opened stream via Func<>.

@bgrainger
Copy link
Member

byte[] would be a reasonable overload, but does require the entire patch file to be in memory.

The patch method needs to read from three simultaneous positions in the Stream simultaneously; a forward-only or non-Seekable Stream would fail (and seeking a regular Stream might be inefficient).

All Streams opened by the Func<Stream> passed to the method are disposed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants