Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on LogosBible.Utility #4

Closed
jzebedee opened this issue Jul 22, 2014 · 0 comments
Closed

Dependency on LogosBible.Utility #4

jzebedee opened this issue Jul 22, 2014 · 0 comments

Comments

@jzebedee
Copy link
Contributor

The BZip2InputStream from ICSharpCode.SharpZipLib.BZip2 has a property named "IsStreamOwner" that makes WrappingStream redundant.

In the interests of reducing external dependencies, I think it would be a good change to remove the LogosBible.Utility reference and just set "IsStreamOwner" to false in the Bzip2InputStream initializer.


Description from the ICSharpCode documentation (http://bit.ly/1nex97g):

bool    IsStreamOwner [get, set]
    Get/set flag indicating ownership of underlying stream. When the flag is true Close will close the underlying stream also. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant