HAST-295: Open-source Hast.Core #98
Conversation
…e to the .NET decompilation result being different
…hanged due to the .NET decompilation result being different
…changed due to the .NET decompilation result being different
…ed due to the .NET decompilation result being different
… various changed due to the .NET decompilation result being different
… due to the .NET decompilation result being different
…due to the .NET decompilation result being different
…d simplifying test classes by removing code that's optimized out by the compiled anyway
… be necessary with Release builds
This reverts commit 23aab87.
| - Their projects need to be located in a subfolder of *Hast.Core*. | ||
| - Both the Debug and Release build output directories should be set just to *bin\\*. | ||
|
|
||
| If a *Hast.Core* projects needs to have types accessible in the Client flavor then create a corresponding `Abstractions` project. Such projects should follow the same rules listed above as *Hast.Core* projects with the only difference being that they should be located in a subfolder of *Hast.Abstractions*. Exceptions are projects that are directly added as imported extensions in `Hast.Layer`: Those can be just normal projects (like `Hast.Transformer.Abstractions`). |
There was a problem hiding this comment.
These are not applicable anymore, but GetHastLibraries() still loads dependencies from the available (hard-referenced) Hast DLLs. We can perhaps change that to use static loading, but for that, we'd need to add a reference to a type in each assembly, which seems like a chore and error-prone in the future if we add new projects.
There was a problem hiding this comment.
I wonder if we can determine the types using some kind of compile time analysis using Roslyn code generation? Then this could be automated away and we'd have one less error source.
There was a problem hiding this comment.
We can iterate over the loaded assemblies instead of the files too, and filter by name there. Apart from the name, we could use a marker attribute in SharedAssemblyInfo, but I don't think that's much better.
There was a problem hiding this comment.
Based on #99 I suggest leaving this as it is for now.
There was a problem hiding this comment.
Yeah, no change request here. I just answered your comment where you wrote it. 😉
Hast.Core/Hast.Transformer/Services/MemberSuitabilityChecker.cs
Outdated
Show resolved
Hide resolved
Hast.Core/Hast.Transformer/Services/MemberSuitabilityChecker.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dávid El-Saig <david.el-saig@lombiq.com>
This reverts commit ce9c35e.
HAST-295
Note to the reviewer: The 9638b69 commit just copies the
devofHast.Core. You can skip that commit. The actual changes come only after commit ef8d2a0.