Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-529: Include dynamic base theme when GetFeatures is called #33

Merged
merged 4 commits into from
Jan 27, 2023
Merged

OSOE-529: Include dynamic base theme when GetFeatures is called #33

merged 4 commits into from
Jan 27, 2023

Commits on Jan 23, 2023

  1. Include dynamic base theme when GetFeatures is called 

    Currently MediaTheme's ExtensionManagerDecorator decorates the
registered IExtensionManager type to include it's dynamically
selected base theme as a MediaTheme dependency.

This works everywhere in OrchardCore (OC) where IExtensionManager
is used with depencency injection (DI).

But, the default implementation ExtensionManager internally calls
GetFeatureDependencies() without DI bypassing MediaTheme's
decoration for including the base theme as a dependency.
    @davidpuplava
    davidpuplava committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9abd697 View commit details
    Browse the repository at this point in the history

  2. Consolidate code to get base theme id

    @davidpuplava
    davidpuplava committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e87e374 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Ensure C# line endings properly handled on non-Windows systems

    @davidpuplava
    davidpuplava committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d642859 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Merge branch 'dev' into issue/OSOE-529

    @davidpuplava
    davidpuplava committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    f118230 View commit details
    Browse the repository at this point in the history