OSOE-598: Add entra authentication for live metrics #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Hey @DemeSzabolcs , I have tested this on an Azure App Service app. Let me know if there are any edge cases / situations that need to be tested that I might not be aware of. I've also marked the Api Key as deprecated and updated the Readme let me know if you'd like to see any changes there. |
Piedone
approved these changes
May 22, 2024
Piedone
requested changes
May 23, 2024
Piedone
approved these changes
Jun 4, 2024
Piedone
approved these changes
Jun 5, 2024
Piedone
approved these changes
Jun 10, 2024
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
This reverts commit 95bb96b.
LombiqBot
added
requires-windows-build
and removed
run-windows-build
requires-windows-build
labels
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-598
Also see: Lombiq/Orchard-Azure-Application-Insights#85