Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-598: Add entra authentication for live metrics #85

Merged
merged 32 commits into from
Jun 14, 2024
Merged

OSOE-598: Add entra authentication for live metrics #85

merged 32 commits into from
Jun 14, 2024

Conversation

AydinE
Copy link
Contributor

@AydinE AydinE commented May 22, 2024 •
edited by jira bot
Loading

OSOE-598
Fixes #56

@AydinE AydinE mentioned this pull request May 22, 2024
Merged
Piedone
Piedone requested changes May 22, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/Extensions/ApplicationInsightsInitializerExtensions.cs Outdated Show resolved Hide resolved
AydinE and others added 9 commits May 23, 2024 10:18
@AydinE @Piedone
Update Readme.md
15d3773 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Readme.md
69b61c9 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Readme.md
e64a501 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOp…
22bec38 
…tions.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE
Support local development
f74854c
@AydinE
Merge branch 'issue/OSOE-598' of https://github.com/Lombiq/Orchard-Az…
6edc181 
…ure-Application-Insights into issue/OSOE-598
@AydinE
Update Readme.md
11ed4b7
@AydinE
Update ApplicationInsightsInitializerExtensions.cs
ef8e256
@AydinE
Update nuget package version
d676e19
@AydinE
Copy link
Contributor Author

AydinE commented May 23, 2024

I've now added a way to use it during local development and added some extra info about it in the readme. I've made it an option that needs to be enabled from the appsettings as it seems that it's in line with how other options for this module are configured.

Piedone
Piedone requested changes Jun 4, 2024
View reviewed changes
Lombiq.Hosting.Azure.ApplicationInsights/Extensions/ApplicationInsightsInitializerExtensions.cs Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
AydinE and others added 6 commits June 5, 2024 09:33
@AydinE @Piedone
Update Readme.md
b8b1f45 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Readme.md
6bd71d5 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Readme.md
b05ab16 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Readme.md
8a73ae7 
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE
Use service principal for local development
dd956de
@AydinE
Update ApplicationInsightsOptions.cs
dddcdfe
Piedone
Piedone requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still confused about how the whole thing is supposed to work with Azure, sorry about that. In either case, something is missing.

Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/Extensions/ApplicationInsightsInitializerExtensions.cs Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOptions.cs Outdated Show resolved Hide resolved
AydinE and others added 6 commits June 6, 2024 08:03
@AydinE @Piedone
Update Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOp…
48865d7 
…tions.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOp…
492dacd 
…tions.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE @Piedone
Update Lombiq.Hosting.Azure.ApplicationInsights/ApplicationInsightsOp…
22b5f9f 
…tions.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@AydinE
Try to clear up some confusion
6538e0a
@AydinE
Add option to use entra
1bfda11
@AydinE
Update Readme.md
390846e
Piedone
Piedone requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing the setup, I clarified the docs directly instead of doing a dozen code suggestions, but please check.

Readme.md Outdated Show resolved Hide resolved
@Piedone Piedone merged commit 6697365 into dev Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for secure Live Metrics channel with AAD authentication instead of API key (OSOE-598)
2 participants
@AydinE @Piedone