Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-661: UI test is flaky, randomly failing with "stale element not found" in Lombiq.BaseTheme #82

Merged
merged 11 commits into from
Jul 25, 2023
Merged

OSOE-661: UI test is flaky, randomly failing with "stale element not found" in Lombiq.BaseTheme #82

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ef4604
Trying to fix flaky UI test
DemeSzabolcs Jul 24, 2023
96639ff
Trying to fix UI test in a different way
DemeSzabolcs Jul 24, 2023
742edbf
Still trying to fix UI tests
DemeSzabolcs Jul 24, 2023
5c15a9f
Trying to fix UI test in a different way
DemeSzabolcs Jul 24, 2023
c2c5511
Using Task.Delay to try to fix the test
DemeSzabolcs Jul 24, 2023
5878f3c
Trying to use just Task.Delay to resolve the issue
DemeSzabolcs Jul 24, 2023
f03e871
Trying to fix UI test a different way
DemeSzabolcs Jul 24, 2023
1455727
Still using Task.Delay to fix the test
DemeSzabolcs Jul 24, 2023
d6e4af0
Trying yet another different fix and adding a comment
DemeSzabolcs Jul 24, 2023
8cb36e0
Spelling
DemeSzabolcs Jul 24, 2023
92a9828
Trying to fix BaseTheme UI test, without using Task.Delay
DemeSzabolcs Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions Lombiq.BaseTheme.Tests.UI/Extensions/TestCaseUITestContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ public static async Task TestBaseThemeSiteSettingsAsync(
await context.GoToAdminRelativeUrlAsync("/Lombiq.BaseTheme/Admin/Index");
await context.SetCheckboxValueAsync(By.Id("HideMenu"), isChecked: true);

var byDeleteButton = By.CssSelector("#Editor .delete-button").OfAnyVisibility();
while (context.Exists(byDeleteButton.Safely())) await context.ClickReliablyOnAsync(byDeleteButton);
await context.ClickReliablyOnAsync(By.XPath("//div[contains(@class, 'thumb-container')]"));
await context.ClickReliablyOnAsync(By.CssSelector("#Editor .delete-button").OfAnyVisibility());

selectFromMediaLibraryAsync ??= async () =>
{
Expand All @@ -109,6 +109,9 @@ await context.ClickReliablyOnAsync(By.XPath(
};
byIcon ??= By.CssSelector("head link[href*='/media/Icons/oc-favicon.ico'][rel='shortcut icon'][type='image/x-icon']");

// We are saving the settings, so we leave some time for the editor button to appear, without using
// Task.Delay().
await context.ClickReliablyOnSubmitAsync();
await context.ClickReliablyOnAsync(By.CssSelector("#Editor .btn-group .btn-secondary:not([disabled]):not(.disabled)"));
await selectFromMediaLibraryAsync();

Expand Down