Set sound for reinforce wall #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The game tried to play the non-existing sound file 172 when imps would reinforce walls. This gave errors, and made no sound. Configured sound 63 to be used instead.
|
@spartahawk and @OrsonMaxwell try this build, have imps reinforce some walls and let me know if you prefer it with this sound, or quit like it was. If you have another sound in mind, feel free to share. (Use DKSound from the DKTools to browse the sounds). |
The game tried to play sound files 80-82 that do not exist in the sound.dat
|
I also made a new sound.dat, that includes sounds 80-82 for chickens hatching. So this pull is enough to consider #39 fixed. |
|
Received positive feedback on this from @OrsonMaxwell , and a message that no feedback is coming on this from @spartahawk , so I'm merging this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game tried to play the non-existing sound file 172 when imps would
reinforce walls. This gave errors, and made no sound.
Configured sound 63 to be used instead.