Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VECHO / V8Power relies on video rows count BIOS variable being initialized, but it is not guaranteed to be initialized #4

Open
skiselev opened this issue Aug 15, 2023 · 0 comments

Comments

@skiselev
Copy link

I've received the a pull request for my 8088 BIOS: skiselev/8088_bios#42

This pull request supposed to fix an issue where the 8088 BIOS does not initialize video row count BIOS variable at 0040:0084.

Upon closer investigation, it appears that the system BIOS is not guaranteed and not supposed to initialize this variable. VGA and EGA BIOS extensions do initialize it though.

The code here

mov bl, [es:0x0084]
should be updated to validate that the BIOS indeed populates the right value in that variable, or use some another way to detect the screen height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant