Mapping of AndroidX artifacts to constants (from Splitties Gradle plugin) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisCAD
changed the title
LouisCAD
commented
Oct 24, 2019
LouisCAD
commented
Oct 24, 2019
This reverts commit 954e9b1
|
I can merge this one, right? |
|
Yes! |
jmfayard
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping is returned as a
List<Pair<String, String>>by thegetArtifactNameToSplittiesConstantMappingfunction in the plugin sources. No need for a CSV file. Kotlin-reflect is already embedded by Gradle so this can be used anytime needed.This PR also includes some cleanup and indentation fix (to match official Kotlin style guide).
Closes #222