Androidx #90
Closed
Androidx #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfayard
added a commit
to LouisCAD/Splitties
that referenced
this pull request
Oct 24, 2019
``` ## Checking that you use compileSdkVersion 28 ✔ 🆗 You are using compileSdkVersion 28 ## Migrating classes from support libraries to AndroidX. ✔ 🆗 Parsing file androidx-class-mapping.csv ✔ 🆗 Modules: [Application] ✔ 🆗 Found 18 source files that may need migration ✔ 🆗 File androidx-class-mapping.csv parsed correctly ✔ 🆗 Starting batch migration... Migrating file "CameraActivity.java" … overwriting file… Done. ✔🆗 Migrating file "Camera2BasicFragment.java" … overwriting file… Done. ✔🆗 Migrating file "build.gradle" … ✔ 🆗 2 source files (kt,java,xml) have been migrated (16 didn't need it). ✔ 🆗 0 gradle files have been migrated (1 didn't need it). ## Detecting Gradle properties ✔ 🆗 gradle.properties already contains [android.useAndroidX, android.enableJetifier] ## Your turn: use instead those Androidx libraries implementation(AndroidX.legacy.supportV4) implementation(AndroidX.legacy.supportV13) implementation(AndroidX.cardView) implementation(AndroidX.appCompat) ```
```
Executing tasks: [refreshVersions] in project /Users/jmfayard/GitHub/camera-samples/Camera2BasicJava
> Task :dependencyUpdates
Failed to resolve :Application:debugAndroidTestCompileClasspath
Failed to resolve :Application:debugCompileClasspath
Failed to resolve :Application:debugUnitTestCompileClasspath
Failed to resolve :Application:releaseCompileClasspath
Failed to resolve :Application:releaseUnitTestCompileClasspath
------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------
The following dependencies are using the latest milestone version:
- androidx.appcompat:appcompat:1.1.0
- androidx.cardview:cardview:1.0.0
- androidx.legacy:legacy-support-v13:1.0.0
- androidx.legacy:legacy-support-v4:1.0.0
- com.louiscad.splitties:com.louiscad.splitties.gradle.plugin:0.1.3
- de.fayard.refreshVersions:de.fayard.refreshVersions.gradle.plugin:0.8.0
The following dependencies have later milestone versions:
- com.android.tools.build:gradle [3.3.2 -> 3.5.1]
- com.android.tools.lint:lint-gradle [26.3.2 -> 26.5.1]
https://developer.android.com/studio
Gradle release-candidate updates:
- Gradle: [5.6.2 -> 5.6.3 -> 6.0-rc-1]
Generated report file build/dependencyUpdates/report.json
> Task :refreshVersions
Running plugins.id("de.fayard.refreshVersions").version("0.8.0") with useRefreshVersions=false and extension: {"alignVersionsForGroups":[],"alwaysUpdateVersions":false,"orderBy":"GROUP_AND_LENGTH","propertiesFile":"versions.properties","useFqqnFor":[]}
See documentation at Splitties/refreshVersions#53
new file: versions.properties
```
jmfayard
added a commit
to LouisCAD/Splitties
that referenced
this pull request
Oct 24, 2019
|
Hi @jmfayard , thanks for opening this PR! It looks like you are doing a lot of things in a pretty non-standard way (at least compared to the rest of the samples). While I agree with the general idea of updating the dependencies to AndroidX, I don't think we can accept this PR unless it's done more similarly compared to, for example, https://github.com/android/camera-samples/tree/master/Camera2Formats |
|
@owahltinez Oh it's a mistake, I didn't intend to actually open a pull-request, I just wanted to compare our branches |
|
Got it. If you change your mind and want to tweak your PR to conform with the rest of the samples, we'd be more than happy to merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.