Add support for cell voltages and TimeToSoC items on dbus #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbus
-battery.py
Help prevent terminating when BMS doesn't return valid SoC data.
- utils.py
Add config variable: BATTERY_CAPACITY
-dbusfelper.py
Add support for individual cell voltages.
Add support for TimeToSoC for 5% SoC.
All times will be positive regardless of whether charge/discharge.
When charging and SoC is >= to a SoC percentage that percentage value will be None (or "-").
When discharging and SoC is <= to a SoC percentage that percentage value will be None (or "-").
If not charging or discharging all TimeToSoC will be None (or "-").
-daly.py
Add cellvolt_buffer to read cell voltages and to accommodate up to 48 cells (Daly current max supported cells).
read_soc_data attempts 3 times to read soc_data from Daly before failing. This greatly increases the read reliability of some Daly devices.
Add function read_alarm_data for most previously defined dbus Alarms items.
Add function read_cells_volts to read read all individual cell voltages for up to 48 cells. Tested only with 4 cell BMS.
Add logger.warning messages to understand which dataset read failed.
Improve validity of data read in read_soc_data by ensuring current value is within acceptable range
Louisvdw
approved these changes
Feb 6, 2022
This was referenced Feb 6, 2022
Thanks for catching that. It is utilized in the get_settings, which I forgot to include the the repo copy. It is there now. Shall I issue another PR for the change? |
|
yes just create a new PR with the missing code and I will add it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-battery.py
Help prevent terminating when BMS doesn't return valid SoC data.
Add config variable: BATTERY_CAPACITY
-dbushelper.py
Add support for individual cell voltages.
Add support for TimeToSoC for 5% SoC.
All times will be positive regardless of whether charge/discharge.
When charging and SoC is >= to a SoC percentage that percentage value will be None (or "-").
When discharging and SoC is <= to a SoC percentage that percentage value will be None (or "-").
If not charging or discharging all TimeToSoC will be None (or "-").
-daly.py
Improve reliability of data read from Daly BMS
Add cellvolt_buffer to read cell voltages and to accommodate up to 48 cells (Daly current max supported cells).
read_soc_data attempts 3 times to read soc_data from Daly before failing. This greatly increases the read reliability of some Daly devices.
Add function read_alarm_data for most previously defined dbus Alarms items.
Add function read_cells_volts to read read all individual cell voltages for up to 48 cells. Tested only with 4 cell BMS.
Add logger.warning messages to understand which dataset read failed.