Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unknown request ID" error shown after reload with errored response #238

Closed
LucasPickering opened this issue May 27, 2024 · 0 comments · Fixed by #260
Closed

"Unknown request ID" error shown after reload with errored response #238

LucasPickering opened this issue May 27, 2024 · 0 comments · Fixed by #260
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@LucasPickering
Copy link
Owner

Describe the bug
A clear and concise description of what the bug is

"Unknown request ID _" error is shown if you reload/restart the app while an in-progress or failed request record is shown on the screen.

To Reproduce
Steps to reproduce the behavior

  1. Send a request that fails (use one of the error profiles in the example collection)
  2. Reload the app
  3. Witness the error modal

Expected behavior
A clear and concise description of what you expected to happen

The previous response should be lost, and we go back to the most recent successful response instead.

Screenshots
If applicable, add screenshots to help explain your problem

image

Version (please complete the following information):

  • Slumber Version: 1.3.2

Additional context
Add any other context about the problem here.

What's happening is the currently selected response is being persisted, but when the app reloads, it's lost because only successful responses are stored in history. We should just be ignoring this error.
@LucasPickering LucasPickering added the bug Something isn't working label May 27, 2024
@LucasPickering LucasPickering modified the milestones: 1.5.0, 1.4.0 Jun 9, 2024
LucasPickering added a commit that referenced this issue Jun 10, 2024
@LucasPickering
Fix "Unknown request ID" on startup
789af28 
This was occurring when the selected request before a reload was unsuccessful, because unsuccessful requests aren't persisted to the DB. Instead of showing an error, we now fall back to selecting the most recent request for the recipe.

Closes #238
@LucasPickering LucasPickering mentioned this issue Jun 10, 2024
Merged
3 tasks
LucasPickering added a commit that referenced this issue Jun 10, 2024
@LucasPickering
Fix "Unknown request ID" on startup
c931040 
This was occurring when the selected request before a reload was unsuccessful, because unsuccessful requests aren't persisted to the DB. Instead of showing an error, we now fall back to selecting the most recent request for the recipe.

Closes #238
LucasPickering added a commit that referenced this issue Jun 10, 2024
@LucasPickering
Fix "Unknown request ID" on startup
037bf4e 
This was occurring when the selected request before a reload was unsuccessful, because unsuccessful requests aren't persisted to the DB. Instead of showing an error, we now fall back to selecting the most recent request for the recipe.

Closes #238
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 17, 2024
net/slumber: update to 1.4.0
8ec556a 
[1.4.0] - 2024-06-11

Added

- Structured bodies can now be defined with tags on the body field of a recipe,
making it more convenient to construct bodies of common types. Supported types
are:
  - `!json` [#242](LucasPickering/slumber#242)
  - `!form_urlencoded` [#244](LucasPickering/slumber#244)
  - `!form_multipart` [#243](LucasPickering/slumber#243)
  - [See docs](https://slumber.lucaspickering.me/book/api/request_collection/recipe_body.html) for usage instructions
- Support multiple instances of the same query param [#245](LucasPickering/slumber#245) (@maksimowiczm)
  - Query params can now be defined as a list of `<param>=<value>` entries
  - [See docs](https://slumber.lucaspickering.me/book/api/request_collection/query_parameters.html)
- Templates can now render binary values in certain contexts
  - [See docs](https://slumber.lucaspickering.me/book/user_guide/templates.html#binary-templates)

Changed

- When a modal/dialog is open `q` now exits the dialog instead of the entire app
- Upgrade to Rust 1.76

Fixed

- Fix "Unknown request ID" error showing on startup [#238](LucasPickering/slumber#238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fix "Unknown request ID" on startup LucasPickering/slumber
1 participant
@LucasPickering