Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Unknown request ID" on startup #260

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

This was occurring when the selected request before a reload was unsuccessful, because unsuccessful requests aren't persisted to the DB. Instead of showing an error, we now fall back to selecting the most recent request for the recipe.

Closes #238

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

It's a bit wonky that we lose requests on reload. I still don't think persisting loading/failed requests is worth the effort, or the disk space.

QA

How did you test this?

  • Tested manually in TUI
  • Added a unit test

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

This was occurring when the selected request before a reload was unsuccessful, because unsuccessful requests aren't persisted to the DB. Instead of showing an error, we now fall back to selecting the most recent request for the recipe.

Closes #238
@LucasPickering LucasPickering merged commit 037bf4e into master Jun 10, 2024
7 checks passed
@LucasPickering LucasPickering deleted the fix-request-error branch June 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unknown request ID" error shown after reload with errored response
1 participant