Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First-class multipart/form-data support #243

Closed
LucasPickering opened this issue May 28, 2024 · 1 comment · Fixed by #258
Closed

First-class multipart/form-data support #243

LucasPickering opened this issue May 28, 2024 · 1 comment · Fixed by #258
Labels
qol Improvements that make usage smoother, without introducing new functionality
Milestone
1.4.0

Comments

@LucasPickering
Copy link
Owner

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Make it easy to send multipart/form-data requests.

Describe the solution you'd like
A clear and concise description of what you want to happen

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered

Additional context
Add any other context or screenshots about the feature request here
@LucasPickering LucasPickering added the qol Improvements that make usage smoother, without introducing new functionality label May 28, 2024
@LucasPickering LucasPickering changed the title First-calss multipart/form-data support First-class multipart/form-data support May 28, 2024
@LucasPickering LucasPickering mentioned this issue May 28, 2024
Closed
@LucasPickering
Copy link
Owner Author

Implementation for this is a little more complicated than I had hoped due to how reqwest handles multipart forms. I don't think this will make it into the next release.

LucasPickering added a commit that referenced this issue Jun 9, 2024
@LucasPickering
Add multipart/form-data support
e073e68 
Add a new structured body type !form_multipart, which allows sending forms with binary data. This is a bit incomplete, we need to support streaming bodies in #256.

Closes #243
@LucasPickering LucasPickering added this to the 1.4.0 milestone Jun 9, 2024
LucasPickering added a commit that referenced this issue Jun 9, 2024
@LucasPickering
Add multipart/form-data support
f281d4f 
Add a new structured body type !form_multipart, which allows sending forms with binary data. This is a bit incomplete, we need to support streaming bodies in #256.

Closes #243
LucasPickering added a commit that referenced this issue Jun 9, 2024
@LucasPickering
Add multipart/form-data support
41fbfd2 
Add a new structured body type !form_multipart, which allows sending forms with binary data. This is a bit incomplete, we need to support streaming bodies in #256.

Closes #243
@LucasPickering LucasPickering mentioned this issue Jun 9, 2024
Merged
3 tasks
LucasPickering added a commit that referenced this issue Jun 9, 2024
@LucasPickering
Add multipart/form-data support
fc30c64 
Add a new structured body type !form_multipart, which allows sending forms with binary data. This is a bit incomplete, we need to support streaming bodies in #256.

Closes #243
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 17, 2024
@0323pin
net/slumber: update to 1.4.0
8ec556a 
[1.4.0] - 2024-06-11

Added

- Structured bodies can now be defined with tags on the body field of a recipe,
making it more convenient to construct bodies of common types. Supported types
are:
  - `!json` [#242](LucasPickering/slumber#242)
  - `!form_urlencoded` [#244](LucasPickering/slumber#244)
  - `!form_multipart` [#243](LucasPickering/slumber#243)
  - [See docs](https://slumber.lucaspickering.me/book/api/request_collection/recipe_body.html) for usage instructions
- Support multiple instances of the same query param [#245](LucasPickering/slumber#245) (@maksimowiczm)
  - Query params can now be defined as a list of `<param>=<value>` entries
  - [See docs](https://slumber.lucaspickering.me/book/api/request_collection/query_parameters.html)
- Templates can now render binary values in certain contexts
  - [See docs](https://slumber.lucaspickering.me/book/user_guide/templates.html#binary-templates)

Changed

- When a modal/dialog is open `q` now exits the dialog instead of the entire app
- Upgrade to Rust 1.76

Fixed

- Fix "Unknown request ID" error showing on startup [#238](LucasPickering/slumber#238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
qol Improvements that make usage smoother, without introducing new functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Add support for multipart/form-data bodies LucasPickering/slumber
1 participant
@LucasPickering