Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config overrides support for Tugboat #388

Closed
justafish opened this issue Feb 1, 2024 · 3 comments · Fixed by #441
Closed

Add config overrides support for Tugboat #388

justafish opened this issue Feb 1, 2024 · 3 comments · Fixed by #441
Assignees
@KeyboardCowboy
Labels
client affected enhancement New feature or request

Comments

@justafish
Copy link
Member

justafish commented Feb 1, 2024 •
edited
Loading

Add support for a config-overrides.yml file that will merge with the auto-generated config.yml file to allow things like service aliases and visual diff support. Initially this should only support

  • aliases
  • urls
  • screenshot
  • visualdiff

and ignore everything else.
@justafish justafish changed the title Add alias support to Tugboat configuration Add config overrides support for Tugboat Feb 1, 2024
@tess-ten7
Copy link

This would be so, so useful for us.

@KeyboardCowboy
Copy link
Contributor

@justafish or @deviantintegral, the ScaffoldInstallerPlugin.php file has a lot going on in it, namely the installCICommands() method. Would it be OK if I split the Tugboat processing into its ScaffoldService class if I'm going to add additional processing for the overrides file?

@KeyboardCowboy KeyboardCowboy mentioned this issue Feb 19, 2024
Merged
@KeyboardCowboy
Copy link
Contributor

I spun up a test/example repo to test these changes. Checking out this branch and running composer install should produce the desired config.yml.

https://github.com/Lullabot/drainpipe-test/tree/388--config-overrides-tugboat

This was referenced Aug 29, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KeyboardCowboy KeyboardCowboy

Labels
client affected enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support a config.overrides.yml file for Tugboat Lullabot/drainpipe
4 participants
@deviantintegral @justafish @KeyboardCowboy @tess-ten7