fix(export-dialog): was not closed when title was missing #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPSchellenberg
added
the
[type] bug
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2021
## [0.5.1](v0.5.0...v0.5.1) (2021-02-21) ### Bug Fixes * **deps:** update dependency @lumieducation/h5p-express to v7.0.2 ([e6f5f8b](e6f5f8b)) * **deps:** update dependency @lumieducation/h5p-html-exporter to v7.0.2 ([75f9097](75f9097)) * **deps:** update dependency @lumieducation/h5p-server to v7.0.1 ([#1254](#1254)) ([eda9ef7](eda9ef7)) * **deps:** update dependency @lumieducation/h5p-server to v7.0.2 ([086e826](086e826)) * **deps:** update dependency @sentry/electron to v2.3.0 ([fc34fbc](fc34fbc)) * **deps:** update dependency @testing-library/react to v11.2.4 ([a43dafe](a43dafe)) * **deps:** update dependency @testing-library/react to v11.2.5 ([#1218](#1218)) ([6319384](6319384)) * **deps:** update dependency @testing-library/user-event to v12.6.3 ([39fa3d1](39fa3d1)) * **deps:** update dependency @testing-library/user-event to v12.7.0 ([54907fb](54907fb)) * **deps:** update dependency @testing-library/user-event to v12.7.1 ([4ea5292](4ea5292)) * **deps:** update dependency @types/node to v12.19.16 ([f5802f0](f5802f0)) * **deps:** update dependency @types/node to v12.20.0 ([a5eee8d](a5eee8d)) * **deps:** update dependency @types/node to v12.20.1 ([26cb252](26cb252)) * **deps:** update dependency @types/node to v12.20.2 ([9acf14e](9acf14e)) * **deps:** update dependency @types/react to v16.14.3 ([594edf0](594edf0)) * **deps:** update dependency @types/react to v16.14.4 ([aaebcf9](aaebcf9)) * **deps:** update dependency @types/react-dom to v16.9.11 ([0a77f5a](0a77f5a)) * **deps:** update dependency electron-log to v4.3.2 ([abc3967](abc3967)) * **deps:** update dependency i18next to v19.8.6 ([8ad28a7](8ad28a7)) * **deps:** update dependency i18next to v19.8.7 ([d95d3ef](d95d3ef)) * **deps:** update dependency i18next to v19.8.8 ([ccae144](ccae144)) * **deps:** update dependency i18next to v19.8.9 ([2d5a9eb](2d5a9eb)) * **deps:** update dependency react-scripts to v4.0.2 ([80ebfba](80ebfba)) * **deps:** update dependency typescript to v4.1.4 ([3dfdea4](3dfdea4)) * **deps:** update dependency typescript to v4.1.5 ([e91ebb8](e91ebb8)) * **deps:** update mui monorepo ([#1204](#1204)) ([35d3546](35d3546)) * **deps:** update sentry monorepo to v6 ([#1179](#1179)) ([8353eba](8353eba)) * **deps:** update sentry monorepo to v6.1.0 ([c51b761](c51b761)) * **deps:** update sentry monorepo to v6.2.0 ([166e3c8](166e3c8)) * **export-dialog:** was not closed when title was missing ([#1247](#1247)) ([0c5f19c](0c5f19c)) * **reporter:** fix big report files due to bg images ([#1229](#1229)) ([2abbc60](2abbc60)), closes [#1226](#1226)
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this PR fixes a bug where the export dialog was not closeable anymore when exporting a file without giving a title.
Now the export dialog should also close on errors.