Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): broken styling (fixes #1320) #1328

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Conversation

JPSchellenberg
Copy link
Member

Hey,

I fixed the broken styling of the analytics page and switched from using the xAPI-Viewer to a custom Lumi integration.

@JPSchellenberg JPSchellenberg self-assigned this Mar 16, 2021
@JPSchellenberg JPSchellenberg added the [type] bug Something isn't working (resulting in patch-version) label Mar 16, 2021
@JPSchellenberg JPSchellenberg changed the title fix(analytics): broken styling fix(analytics): broken styling (fixes #1320) Mar 16, 2021
@sr258
Copy link
Member

sr258 commented Mar 17, 2021

Styles look ok. There are unlocalized strings in analyticRoutes.ts

@sr258 sr258 merged commit 0e4cf8e into master Mar 17, 2021
github-actions bot pushed a commit that referenced this pull request Mar 17, 2021
## [0.5.3](v0.5.2...v0.5.3) (2021-03-17)

### Bug Fixes

* **analytics:** fixed broken styling in Analytics ([#1328](#1328)) ([0e4cf8e](0e4cf8e)), closes [#1320](#1320)
* **deps:** update dependency @testing-library/user-event to v13 ([#1327](#1327)) ([3ecb500](3ecb500))
* **deps:** update dependency @types/react to v17.0.3 ([#1222](#1222)) ([aa10eb4](aa10eb4))
* **i18n-af:** add af to LanguageList ([#1338](#1338)) ([f643915](f643915))
* **i18n-af:** improve translation by Victor Correia ([#1336](#1336)) ([f3dbc96](f3dbc96))
* **locales:** fixed translations of h5p-server ([#1333](#1333)) ([62a86a7](62a86a7))
* **menu:** websocket-actions are named correct ([#1339](#1339)) ([c38e4d5](c38e4d5))
@github-actions
Copy link

🎉 This PR is included in version 0.5.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JPSchellenberg JPSchellenberg deleted the fix/analytics-style branch April 2, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [type] bug Something isn't working (resulting in patch-version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants