Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Game from 2023.510.0 to 2023.605.0 #461

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2023

Bumps ppy.osu.Game from 2023.510.0 to 2023.605.0.

Release notes

Sourced from ppy.osu.Game's releases.

2023.605.0

What's Changed

Code Quality

Database

ppy/osu#23695@​peppy)

A couple of fixes here:

  • Previously, if the backup procedure failed, startup would continue and the user's realm database may be deleted. I think in such a fail case I'd rather the game didn't startup so the user gets in touch (or reads the log files themselves) rather than potentially losing data.
  • Reduced the number of cases a database would be marked as "corrupt". We've seen a couple of reports where a user has provided a "corrupt" database that has worked just fine, so hopefully this change will stop that happening.

Editor

ppy/osu-resources#257@​nekodex)

Did a pass on the metronome samples, mainly to remove the pre-delay before the main transient, but also to make it 'snappier' overall. This should make it easier to hear over music and judge timing more accurately.

I originally had the pre-delay there to help soften the attack of the metronome (so it would sound more organic and less ear-piercing) under the assumption that people would be using it in conjunction with the visual waveform in the editor to dial in the timing/offset. However, it seems some people prefer to use their ears when timing and a pre-delay/offset messes with their ability to do that. Hopefully these new samples will resolve that.

ppy/osu#23508@​peppy)

With default bindings, this restored hitting "Escape" to exit placement mode.

ppy/osu#23509@​peppy)

Just like in the osu! stable editor, you can now switch from slider to select or hitcircle placement and it will place an in-progress slider rather than throwing it away.

ppy/osu#23564@​peppy)

Broke at some point recently.

ppy/osu#23582@​peppy)

osu.Game.Tests.2023-05-17.at.08.55.03.mp4

Of note, in stable the way the editor behaves is slightly differently. The placement object is inserted into the beatmap before being placed, causing future objects to update their combo index, colour, etc.

I'm not ready to commit to that same behaviour (it will be more complicated to manage), but will deal with feedback on this in the future.

... (truncated)

Commits
  • f828992 Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail
  • 4daf1fc Merge pull request #23721 from peppy/fix-mania-hold-not-early-hit
  • b4ab3c8 Merge pull request #23701 from EVAST9919/editor-timeline-fix
  • 8433813 Merge branch 'master' into editor-timeline-fix
  • c2d89a3 Adjust inline comment
  • 03eb7c7 Fix nullability
  • 949fe32 Use combined area of children as a mask instead
  • 00bf79d Merge pull request #23691 from smoogipoo/mania-scroll-speed
  • 98f35f7 Fix osu!mania hold notes snapping to judgement area too early on early hits
  • 289f0e9 Use FireAndForget to avoid unobserved exception
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ppy.osu.Game](https://github.com/ppy/osu) from 2023.510.0 to 2023.605.0.
- [Release notes](https://github.com/ppy/osu/releases)
- [Commits](ppy/osu@2023.510.0...2023.605.0)

---
updated-dependencies:
- dependency-name: ppy.osu.Game
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 5, 2023
Also use mania's ScoreV2 formula, might need finetuning later on.
@LumpBloom7 LumpBloom7 force-pushed the dependabot/nuget/ppy.osu.Game-2023.605.0 branch from 355055f to 90ae36c Compare June 5, 2023 12:57
@LumpBloom7 LumpBloom7 merged commit 8037ee0 into master Jun 5, 2023
3 checks passed
@LumpBloom7 LumpBloom7 deleted the dependabot/nuget/ppy.osu.Game-2023.605.0 branch June 5, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant