Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --fwo(--force-windowed-origin) on xcb, xlib, wayland and metal #1528

Open
locke-lunarg opened this issue May 1, 2024 · 0 comments
Open
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. replay Issue with replay (capture was successful) vulkan

Comments

@locke-lunarg
Copy link
Contributor

locke-lunarg commented May 1, 2024

Now, win32 supports --fwo that set window position.
c6f085a

The other platforms don't. Here is a branch to support it on xlib, xcb and wayland.
locke-lunarg@abfb7c7

But it didn't get test. vkcube and SaschaWillems's examples don't use xlib. The window position on xcb couldn't be changed. I don't know the reason. gfxr can't set Wayland window position.
https://github.com/LunarG/gfxreconstruct/blob/dev/framework/application/wayland_window.cpp#L210

FYI, gfxr doesn't capture if the application runs full screen mode or not. During replay, it checks if the replay resolution is the same to the screen resolution or not to decide if it runs full screen mode or not. It means although vkcube doesn't support full screen, it could still replay with full screen mode if the resolution is the same to the screen resolution. Plus, if it has multiple monitors, the screen resolution that gets by system could be the total of the all monitors.

@locke-lunarg locke-lunarg added the replay Issue with replay (capture was successful) label May 1, 2024
@locke-lunarg locke-lunarg changed the title Support --fwo(--force-windowed-origin) on xcb, xlib, wayland and metal. Support --fwo(--force-windowed-origin) on xcb, xlib, wayland and metal May 1, 2024
@bradgrantham-lunarg bradgrantham-lunarg added P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. android vulkan and removed android labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. replay Issue with replay (capture was successful) vulkan
Projects
None yet
Development

No branches or pull requests

2 participants