Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Skip Network - option to enable network by default? #19

Closed
SandeMC opened this issue Feb 14, 2024 · 5 comments
Closed

Comments

@SandeMC
Copy link

SandeMC commented Feb 14, 2024

Feature Summary:

If you enable SkipNetwork, it disables network by default. Is it possible to have an option in the config to enable it by default, instead? Really a non-issue, it decreases boot time significantly anyway, but hey, why not if it can be done.

Is your proposal related to a problem?

Nope

Describe the solution you'd like

An option in the config

Describe alternatives you've considered

Coping

@SandeMC SandeMC changed the title [Feature Request]: Skip Network - option to enable by default? [Feature Request]: Skip Network - option to enable network by default? Feb 14, 2024
Lyall added a commit that referenced this issue Feb 14, 2024
@Lyall
Copy link
Owner

Lyall commented Feb 14, 2024

image

Thank you for the laugh. I'll change it so that SkipNetwork is enabled by default in the next version. I assume most people would rather the fast boot-up and then just to dip-in to the options menu if they want to turn the network stuff back on.

@SandeMC
Copy link
Author

SandeMC commented Feb 14, 2024

Oh, no, you misunderstood what I meant - I want the actual network capabilities to be set in the config, as in, if you enable SkipNetwork, you can also set a config for whether it should enable or disable the network features after skipping - saves the hassle of both pressing it on startup or setting it in the in-game settings.

@Lyall
Copy link
Owner

Lyall commented Feb 14, 2024

Oh, no, you misunderstood what I meant - I want the actual network capabilities to be set in the config, as in, if you enable SkipNetwork, you can also set a config for whether it should enable or disable the network features after skipping - saves the hassle of both pressing it on startup or setting it in the in-game settings.

Aha I get what you mean now. Will have a look at this.

@Lyall
Copy link
Owner

Lyall commented Feb 21, 2024

Added this in v1.1.2. It can look a little janky as the network features dialog pops-up for a split-second but I'm afraid I can't do any better than that!

@SandeMC
Copy link
Author

SandeMC commented Feb 21, 2024

It's alright, thanks for your work!

@SandeMC SandeMC closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants