Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 upgrade clarification #525

Closed
alex-phillips opened this issue May 1, 2020 · 2 comments · Fixed by #531
Closed

v4 upgrade clarification #525

alex-phillips opened this issue May 1, 2020 · 2 comments · Fixed by #531

Comments

@alex-phillips
Copy link
Contributor

@ildyria I'm working on the LSIO container for v4 (this is hackerman in the Discord!). Just wanted to clarify a couple of things to make sure I have the upgrade running as smoothly as possible:

  1. It looks like the upgrade resets the admin account. I haven't tried it with multiple users. But if I try and upgrade from an existing v3 installation to v4, the first page load prompts me to create the admin account. Is this normal?
  2. Regarding video thumbnail generation - in the past we had to slightly modify the code to include the ffmpeg binary paths. It doesn't look like if I upload a video it's generating a thumbnail. Anything special we need to do here?
  3. It looks like all of the settings are getting reset. Is there a way to preserve settings?

If you want to chat in discord, just ping me! Thanks again for the great project!

@d7415
Copy link
Contributor

d7415 commented May 1, 2020

  1. It looks like the upgrade resets the admin account. I haven't tried it with multiple users. But if I try and upgrade from an existing v3 installation to v4, the first page load prompts me to create the admin account. Is this normal?

I think that's deliberate.

  1. Regarding video thumbnail generation - in the past we had to slightly modify the code to include the ffmpeg binary paths. It doesn't look like if I upload a video it's generating a thumbnail. Anything special we need to do here?

If you need to change the binary paths you'll need to look here or figure out why it's not in php's PATH.

  1. It looks like all of the settings are getting reset. Is there a way to preserve settings?

Many of the settings are different. We might migrate some, but I'd have to look - @ildyria might know. If you want to write something to migrate specific settings, look at the migrations in database/migrations/.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

  1. It looks like the upgrade resets the admin account. I haven't tried it with multiple users. But if I try and upgrade from an existing v3 installation to v4, the first page load prompts me to create the admin account. Is this normal?

I think that's deliberate.

Actually this is necessary. The v4 uses the Laravel facade to generate the hash and verify them while Lychee v3 does this manually. The v4 has thus the agility to switch between different hashing schemes.

It looks like all of the settings are getting reset. Is there a way to preserve settings?

Indeed, but some of the settings might be portable. To be honest I just did not bother. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants