Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizing to a smaller window works in macOS, but not to a window larger than the default size #46

Closed
jacobmischka opened this issue Dec 20, 2022 · 2 comments · Fixed by #48
Closed

Resizing to a smaller window works in macOS, but not to a window larger than the default size #46

jacobmischka opened this issue Dec 20, 2022 · 2 comments · Fixed by #48

Comments

@jacobmischka
Copy link

Pretty much the title. The fact that it only happens when upsizing and not downsizing makes me think it's a bug in this project and not GTK's macOS implementation itself. I'm looking into this myself as it obviously doesn't reproduce on Linux, but if you have any ideas of where to look that would help a lot!

nvim-gtk-macos.mp4

Technical information (please complete the following information):

  • OS: macOS
  • Neovim version: 0.8.1
  • Neovim-Gtk build version: a3b9af7
@jacobmischka jacobmischka mentioned this issue Dec 21, 2022
Merged
@Lyude
Copy link
Owner

Lyude commented Dec 21, 2022

This looks like a gtk4 bug on OSX possibly? I can't think of any other reason why doing something like changing the background styling would do break something like this. Have you tried the gtk inspector (I added call rpcnotify(1, 'Gui', 'Command', 'ShowGtkInspector') a while ago for this) to see if setting the background class there instead of in style.css makes any difference?

@jacobmischka
Copy link
Author

Yes, that's how I found that the CSS class fixed it by using the inspector.

@Lyude Lyude closed this as completed in #48 Dec 21, 2022
Lyude pushed a commit that referenced this issue Dec 21, 2022
@jacobmischka @Lyude
Don't apply nvim-background class on macos, no background breaks windows
3e90c83 
Fixes #46
Lyude pushed a commit that referenced this issue Dec 27, 2022
@jacobmischka @Lyude
Don't apply nvim-background class on macos, no background breaks windows
c22cf59 
Fixes #46
Lyude added a commit that referenced this issue Dec 27, 2022
@Lyude
v1.0.2
94e5d99 
New stable release, bugs fixed:

* OSX (thanks @jacobmischka)
  * #46 - Workaround transparent windows bug in GTK4
  * Disable default shortcuts
* All
  * Fix appearance of error window that displays when initialization fails,
    which regressed since GTK4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace rgba CSS with opaque color jacobmischka/neovim-gtk
2 participants
@Lyude @jacobmischka