Replace rgba CSS with opaque color #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This workaround would be a bit too broad unfortunately - this change came from #38 , basically we make the background transparent so that the viewport can control the opacity (this is used for the |
jacobmischka
force-pushed
the
fix-macos-background
branch
from
84eb624
to
392f606
Compare
jacobmischka
force-pushed
the
fix-macos-background
branch
from
392f606
to
787cebc
Compare
|
Alright, fair enough. I changed the PR to conditionally remove that class name on macos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was apparently breaking macOS windows somehow?
Fixes #46