Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does "on" mean that it is blocking animated gifs or not? #4

Closed
Tectract opened this issue Mar 29, 2020 · 5 comments
Closed

Does "on" mean that it is blocking animated gifs or not? #4

Tectract opened this issue Mar 29, 2020 · 5 comments

Comments

@Tectract
Copy link

I don't know whether "on" means that it is blocking gifs or not. I'm still getting animation on youtube when I onmouseover a video so it doesn't seem like it's blocking gifs, to me.

@M-Reimer
Copy link
Owner

That's most probably not a GIF but a real video.

But to answer the question: "On" means animated gif files are enabled.

@Tectract
Copy link
Author

On should mean animated gifs are DISABLED. The point of this add-on is to DISABLE animated gifs, right? It should at least be clarified, somewhere, lol.

@M-Reimer
Copy link
Owner

The point is to toggle the status of them and "on" means "on".

The tooltip even says "Animate GIF (on)" so animated GIF's are on.

@Tectract
Copy link
Author

If the purpose of the addon is to block animated gifs, then "on" should mean it's blocking animated gifs. Tooltips are bad design. Instead of "on/off" you should instead use "blocking/allowed" to make it clear. Or add something that tells people whether "on" means it's blocking gifs or not.

@M-Reimer
Copy link
Owner

Actually it does not block anything. It toggles a setting:

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browserSettings/imageAnimationBehavior

I have many such "toggle add-ons" and they all behave the same and they all have "on" when the toggled setting is "on" and "off" if the toggled setting is "off".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants