Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove files when generate report fail #250

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

ThomasBouche
Copy link
Collaborator

Description

When generate report, with method xpl.generate_report() and method fail, temporary files are not removed. it can saturate the temporary memory.

Set up Try except

Fixes #249

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • OS:Linux
  • Python version:3.8
  • Shapash version:1.5.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ThomasBouche ThomasBouche merged commit e9d84bf into MAIF:master Sep 28, 2021
@ThomasBouche ThomasBouche deleted the hotfix/remove_files_report branch September 28, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Report files in tmp dir when generate_report fail
2 participants