Subdomain-specific website themes #355
Conversation
`get_relative_static` tokens in files whose names end with `.interpolated` are replaced with the path of another static file.
In addition to adding unique favicons for the `internal` and `admin` subdomains, this also improves how the site is displayed in various contexts, like as app (shortcut) icons on iOS, Android and Windows 8/10, and on the MacBook touch bar. All of the files within the `favicons` folders were generated at https://realfavicongenerator.net/. (Added the comments in `style.css`, to facilitate searching through the codebase for those hex colors, which appear in multiple favicon-related files.)
Codecov Report
@@ Coverage Diff @@
## dev #355 +/- ##
==========================================
+ Coverage 82.72% 82.84% +0.12%
==========================================
Files 117 118 +1
Lines 4161 4192 +31
==========================================
+ Hits 3442 3473 +31
Misses 719 719
Continue to review full report at Codecov.
|
* Added an SVG favicon for each of the subdomains * Reordered the <link> tags in `web/favicon.html`, so that the're sorted from lower to higher quality (when multiple icons are appropriate, the browser selects the last one; see https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types in the row for "icon") * Regenerated the contents of the `favicons` folders (using https://realfavicongenerator.net/), as some of the colors in the previously generated logos were slightly off compared to the colors in MAKE's graphic charter * Replaced `rel="shortcut icon"` with `rel="icon"`, as the `shortcut` link type is deprecated (see the same link as above)
…abstraction-and-styling # Conflicts: # locale/nb/LC_MESSAGES/django.mo # locale/nb/LC_MESSAGES/django.po
There was a problem hiding this comment.
I dissagree with the favicons, the backgrounds makes it more difficult to see the logo, especially the main one (the one with white background).
One solution (that i would suggest) is to have the same favicon for all subdomains (a transparent one).
Another solution is to have the main one be transparent and the rest of the subdomains as the different colored ones
This was changed in 90c56da.
This was done after feedback on the favicons being too difficult to discern from the background. Also made the corners of the favicons rounded (50 pt radius - compared to a width/height of 200 pt).
That's fair 😅 I added the changes we discussed in 51f6c84 🙂
Just to reiterate what came out of our discussion, having a transparent favicon should ideally be avoided, as the logo becomes hard to see if the tabs of a user's browser has e.g. a light/yellow background color (at least as long as the favicon doesn't have its own border to make it easier to discern the logo from any background color), and so the solution added in the commit mentioned above seems better. @sigtheidiot Could you try seeing how the favicons look now? 😊 |
|
Btw, the tests should succeed after #400 has been merged 🙂 |
Yeah, I left it out, since the subdomain is a work in progress (according to the last developer who was working on it), and because I kinda couldn't be bothered finding/making yet another variation of the logo 😅 Also, I thought of the docs as kind of being part of the main site, since they're both public - unlike the internal and admin domains, which both require special permissions to visit 🙂 |
|
@sigtheidiot Alright, I can wait for you to have time to check it out, before merging, if you want 😊 |
|
@ddabble Checked them out in browser now. The rounded corners really make a difference and I think they look really good ❤️ |
# Conflicts: # web/templates/web/base.html
Depends on #354, and should change base to
devafter that PR has been merged.Highlights:
base_site.html(acc1664)