Fix article image heights + failing tests #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by using the images' `naturalHeight` property without making sure that the images were completely loaded, which caused `naturalHeight` to be 0.
Also renamed it to the standard `robots.txt`.
This was mainly for preventing the CI server (GitHub Actions) from testing with too new versions of the required packages, which caused the testing to fail. In the case that prompted this change, it was `django-hosts` that hadn't yet added support for the newest version of Django (which was released yesterday), which caused the following error: `ImportError: cannot import name 'ugettext_lazy' from 'django.utils.translation'`
Codecov Report
@@ Coverage Diff @@
## dev #400 +/- ##
==========================================
- Coverage 82.77% 82.74% -0.03%
==========================================
Files 117 117
Lines 4150 4150
==========================================
- Hits 3435 3434 -1
- Misses 715 716 +1
Continue to review full report at Codecov.
|
Maisergodt
approved these changes
Jan 7, 2022
# Conflicts: # requirements.txt
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
robots.txtfiles (f43c679, 590e183, 1e01ca4)>=with==inrequirements.txt(fb9332c)