Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More diverging colour maps #2

Closed
MBravoS opened this issue Jul 6, 2021 · 5 comments
Closed

More diverging colour maps #2

MBravoS opened this issue Jul 6, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@MBravoS
Copy link
Owner

MBravoS commented Jul 6, 2021

Our initial selection of diverging colour maps was rather opinionated, with only some colour pairs used (based mostly on personal preference) and biased towards maps that diverge from black (uniform maps that diverge from white are more common). We should expand our selection to any colour pair that is friendly at least at least for green-red colour blindness, as there is no good reason not to.

@MBravoS MBravoS added the enhancement New feature or request label Jul 6, 2021
@AstroRobin
Copy link
Collaborator

Added four new diverging colourmaps in v0.4.0, including BwG, CwO, PwO, YkB.

@MBravoS
Copy link
Owner Author

MBravoS commented Jul 15, 2021

@AstroRobin any particular reason for using a different lightness dynamic range compared to the previous diverging colour maps?

@AstroRobin
Copy link
Collaborator

The issue really comes down to the fact that for, at least, OwC and OwP, it is almost impossible to get a set of extremely dark oranges without looking way too brown. The current dynamic range is set from 20-80 which sacrifices consistency in the central grey/white but gives what I think is a fairly nice colour map.

Happy to remove these if we don't think they can be improved given our constraints

@MBravoS
Copy link
Owner Author

MBravoS commented Sep 6, 2021

I have added a bunch of new black-centred diverging colour maps (BkO, BkT, GkM, OkM, PkM, PkR, PkY, TkG, TkP, TkR and TkY). I think several work fine, but I'm fully convinced about the colourblind friendliness of some (GkM, OkM, TkP and TkR), and PkM/PkR may be too close to each other, what do you think @AstroRobin?

@MBravoS
Copy link
Owner Author

MBravoS commented Dec 3, 2021

Expanded also the selection of white-centred diverging maps with v0.8.0. I think with the current selection we can close this issue.

@MBravoS MBravoS closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants