Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]Resampling should be applied to the transposed image #27

Closed
JiaminRen opened this issue Aug 20, 2021 · 2 comments
Closed

[Bug]Resampling should be applied to the transposed image #27

JiaminRen opened this issue Aug 20, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@JiaminRen
Copy link

nnDetection/nndet/inference/restore.py

Line 107 in 61d46a7

fmap_old_spacing = resample_data_or_seg(fmap, size_after_cropping, is_seg=False,

@mibaumgartner
Copy link
Collaborator

Hi @JiaminRen ,

you are right, great catch! The function is only used inside the SegmentationEnsembler in case the segmentation output from Retina U-Net needs to be reconstructed for a whole patient. Since we didn't use it for any of our experiments I'll mark it as an experimental feature for now.

Best,
Michael

@mibaumgartner mibaumgartner added the bug Something isn't working label Aug 20, 2021
@mibaumgartner
Copy link
Collaborator

Was fixed in 537a303

@baibaidj baibaidj mentioned this issue Nov 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JiaminRen @mibaumgartner