Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment and Distribution no effect in upload_sample / upload_samplelist #129

Closed
baderj opened this issue Oct 27, 2017 · 1 comment
Closed
Assignees

Comments

@baderj
Copy link
Contributor

baderj commented Oct 27, 2017

The upload_sample and upload_samplelist routines bot accect a comment and distribution argument. However, they do not have any effect. The comment is never set, and the distribution of the sample is set to Organization.

You can reproduce the issue with upload.py in the example folder:

python3 upload.py -u upload.py -e 200 --distrib 3 --comment "Comment"

Tested with commit 14bc9e4, Thu Oct 26 12:05:51 2017 -0400.

@Rafiot Rafiot self-assigned this Oct 27, 2017
@Rafiot
Copy link
Member

Rafiot commented Nov 2, 2017

So there are a few things here:

  1. the upload method was always creating a new event (upload_sample always creates new event #123), the fix is coming
  2. The comment is passed properly: in the comment of the object, not of each attribute
  3. The distribution was in fact not properly passed, the fix is coming too.
  4. Not passing any distribution information fallback to Organisation (instead of inherit). But I'm going to put this bug in @iglocska's backyard :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants