Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public profile URL should not be based on email address #57

Closed
tompollard opened this issue Dec 11, 2017 · 5 comments
Closed

Public profile URL should not be based on email address #57

tompollard opened this issue Dec 11, 2017 · 5 comments

Comments

@tompollard
Copy link
Member

I thought we'd raised an issue for this, but I can't see it so maybe not. Currently the personal profile URL includes the user email address (e.g. http://127.0.0.1:8000/users/tester@mit.edu/).

It would be better if the URL was based on a unique user hash (or perhaps a user specified username), because ideally the link should be persistent (even if the user updates their email address/es).

@cx1111
Copy link
Member

cx1111 commented Dec 11, 2017

That makes sense. Does the primary key uuid work? Also it's better that we determine whether or not we want usernames early on. Yes or no?

@tompollard
Copy link
Member Author

Does the primary key uuid work?

If we decide to use a unique id, I feel like it might be better to create one specifically for this purpose because it gives us more control/flexibility. If the primary key is an incrementing sequence then we reveal some info about the size of our user database (number of registrants) and make it easy for people to iterate through urls and harvest profiles. If the primary key id is a random hash then it might contain words/numbers that the user dislikes.

it's better that we determine whether or not we want usernames early on. Yes or no?

I just chatted with Alistair and our preference is yes for a user generated username. I don't have a strong reason for this, just that I think people like having a username. Any good arguments for not having a username?

@cx1111
Copy link
Member

cx1111 commented Dec 11, 2017

The pk is an incrementing sequence. Good point about harvesting. So then we can use a specifically generated value. However, if we allow usernames, then could we just use that instead?

For usernames, I find them useful or annoying, depending on whether or not they are necessary for the particular site. If not, it's just an extra field to keep track of on our end and their end. ie. useful on github because it's about code sharing, and (potentially) useless on evernote.

@tompollard
Copy link
Member Author

if we allow usernames, then could we just use that instead?

Yeah, this sounds good to me. It's possible that we might support changes to usernames, which would break the "urls should be persistent" comment above, but oh well. I feel like they will change less often than email address.

For usernames, I find them useful or annoying, depending on whether or not they are necessary for the particular site.

Good point. In our case I think usernames could be integrated into the site to good effect, though no particularly good ideas how right now (e.g. perhaps when authors are adding co-authors to paper they can refer to them by username; perhaps when listing top contributors etc on the website).

@cx1111 cx1111 mentioned this issue Dec 11, 2017
@elfeto
Copy link
Collaborator

elfeto commented Dec 14, 2017

If we use usernames, then why would we keep the login key as the email instead of the username? Then it would be the django default.

@elfeto elfeto closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants