Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from dpericated opencv API #61

Closed
wants to merge 3 commits into from
Closed

Conversation

ruffsl
Copy link
Contributor

@ruffsl ruffsl commented May 5, 2020

Fixes #60

@ToniRV
Copy link
Collaborator

ToniRV commented May 10, 2020

Nice, seems like very small changes, is this OpenCV 3.3.1 backwards compatible?
I mean obviously they are not looking at CI. It would be nice if we could support both though.
Otherwise, we will keep this as a separate branch.

@ruffsl
Copy link
Contributor Author

ruffsl commented May 10, 2020

I'm not sure. Do you see a way this could support both? Looks like headers massage have changed between the two and we may just need some if defs.

@akashsharma02
Copy link

Is there any plan on getting this merged, looks like there was some problem with OpenCV installation in the docker environment? If not I can submit another PR for this.
Also, I do not think OpenCV 4 is backwards compatible with OpenCV 3, because the anonymous enums used have been redefined now.

@ruffsl
Copy link
Contributor Author

ruffsl commented Jun 27, 2020

@akashsharma02 , do you see anything else this might need?

@akashsharma02
Copy link

akashsharma02 commented Jun 30, 2020

@ruffsl I'm actually not sure since the failure was a build issue with OpenCV. I have a fork with the minor changes I've made, maybe you can take a look at that.

@ToniRV
Copy link
Collaborator

ToniRV commented Sep 5, 2020

Closing as #100 allows for OpenCV 3 & 4, thanks!

@ToniRV ToniRV closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Ubuntu 20.04 LTS and OpenCV v4.2
3 participants