Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message parsing #48

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Update message parsing #48

merged 2 commits into from
Feb 9, 2022

Conversation

ehanson8
Copy link
Contributor

@ehanson8 ehanson8 commented Feb 9, 2022

What does this PR do?

  • Update parsing of SQS messages in listen function
  • Fixture updates to better reflect actual environment

How can a reviewer manually see the effects of these changes?

Ensure unit tests still pass by running pipenv run pytest

Requires Database Migrations?

NO

Includes new or updated dependencies?

NO

awd/cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@osmandin osmandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added. Could you also update the commit message to provide context for why this commit is needed?

* Update parsing of SQS messages in listen function after error in database updates
* Fixture updates to better reflect actual environment
@ehanson8 ehanson8 merged commit 4b58a65 into main Feb 9, 2022
@ehanson8 ehanson8 deleted the message-parsing branch February 9, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants